[Improvement-18039][Metrics] Add missing metrics for workflow and task state transitions#18038
Open
sanjana2505006 wants to merge 11 commits intoapache:devfrom
Open
[Improvement-18039][Metrics] Add missing metrics for workflow and task state transitions#18038sanjana2505006 wants to merge 11 commits intoapache:devfrom
sanjana2505006 wants to merge 11 commits intoapache:devfrom
Conversation
sanjana2505006
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
sanjana2505006
force-pushed
the
Improvement-Metrics
branch
from
990a504 to
6176e33
Compare
sanjana2505006
changed the title
sanjana2505006
changed the title
sanjana2505006
changed the title
sanjana2505006
changed the title
SbloodyS
reviewed
Mar 9, 2026
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
Please follow the pull request notice and create an issue first. @sanjana2505006
sanjana2505006
changed the title
sanjana2505006
force-pushed
the
Improvement-Metrics
branch
from
9c47397 to
c0013cc
Compare
Contributor
Author
Member
|
Please check the failed CI. @sanjana2505006 |
Contributor
Author
|
Sure, @SbloodyS, I have an exam today. I’ll take a look at the failed CI once I’m done 😃... |
sanjana2505006
force-pushed
the
Improvement-Metrics
branch
from
2a2647b to
edeef4e
Compare
Contributor
Author
|
Hello @SbloodyS, I've updated the PR to address the CI failures. Please have a look when you have time and share your feedback. Thank you! |
|
…arQube coverage gate, and fix import style in WorkflowExecutionRunnableFactory
Member
|
UT still failed. @sanjana2505006 |
ruanwenjun
reviewed
Mar 20, 2026
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Thanks for your PR.
It might be better to add event metrics first.
WorkflowEventBusFireWorker#doFireSingleWorkflowEventBus
We may need to provide a public method to handle changes in instance state, and then use listeners or similar mechanisms to update the metrics.
So it’s not suitable to add this directly at the moment, but I’ll be doing that soon.
| // The task instance is not active, means it is already finished. | ||
| return; | ||
| } | ||
| org.apache.dolphinscheduler.server.master.metrics.TaskMetrics.incTaskInstanceByState("timeout"); |
Member
There was a problem hiding this comment.
Suggested change
| org.apache.dolphinscheduler.server.master.metrics.TaskMetrics.incTaskInstanceByState("timeout"); | |
| TaskMetrics.incTaskInstanceByState("timeout"); |
| taskInstance.setState(TaskExecutionStatus.FAILURE); | ||
| taskInstance.setEndTime(taskFatalEvent.getEndTime()); | ||
| taskInstanceDao.updateById(taskInstance); | ||
| TaskMetrics.incTaskInstanceByState("fail"); |
Member
There was a problem hiding this comment.
Suggested change
| TaskMetrics.incTaskInstanceByState("fail"); | |
| TaskMetrics.incTaskInstanceByState(TaskExecutionStatus.FAILURE); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds missing metrics to the Master module to improve visibility into workflow and task execution states. It addresses the gap where several metrics classes were defined but not utilized in the core execution flow.
Proposed Changes
AbstractWorkflowStateAction.AbstractTaskStateAction.TaskTimeoutLifecycleEventHandler.WorkflowExecutionRunnableFactory.Verification
mvn spotless:apply.This PR closes #18039